feat: pylint with modern pylintrc #189
Draft
+646
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This seems ok. It only explicitly sets up pylint for vscode, but that seems ok. It's present on the image by default and I haven't bothered committing pycharm configurations to the project so far...
There are a whole lot of violations:
Pylint found 98 errors, 249 warnings, 514 conventions, 291 refactors in 96 files
Should we tweak the rules a bit now or commit this and adjust as we go? A lot of the complaints are obvious false alarms (migration filenames don't conform to snake case, SomeClass = apps.get_model(...) is mistaken for a variable name, etc)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare to #188.
Instead of fixing that old .pylintrc, start with a default generated one and change it into what we want.